Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the host Python to handle the build #1

Closed
wants to merge 1 commit into from
Closed

Conversation

lazka
Copy link
Member

@lazka lazka commented Jul 26, 2020

This way building packages doesn't depend on msys2 packages

@eine

This way building packages doesn't depend on msys2 packages
@eine
Copy link
Contributor

eine commented Jul 26, 2020

It seems that this PR includes three features:

  • Using the host Python instead of packages python and python-pip installed through pacman. I think this is an adequate change.
  • Executing Python from Powershell instead of doing it from MSYS2's bash.
    • Calling msys2.cmd instead of bash, from Python.

The last point makes the pytest script non-portable. It will work in GHA only, because msys2.cmd is not expected to exist in any other environment. Hence, I think it would be desirable to call Python from MSYS2's bash, thus preserving the current buildqueue.py.

@lazka
Copy link
Member Author

lazka commented Jul 26, 2020

OK, so your goal is to make the build script work on GHA and on a local machine?

@eine
Copy link
Contributor

eine commented Jul 26, 2020

@lazka, yes. For two purposes:

  • Make it easier to debug problems with the script/logic.
  • Allow to distribute the workload. The "local machine" might be another CI service, or the server/VPS of some maintainer. Similarly to other distributed systems, where multiple agents can "compete" to be the first in solving some issue (in this case, building a package). Anyway, ideally, if multiple machines are available, it would make sense to schedule the workload explicitly.

@lazka
Copy link
Member Author

lazka commented Jul 26, 2020

OK, sounds good, I'll keep that in mind.

@lazka lazka closed this Jul 26, 2020
@lazka lazka deleted the use-host-python branch July 27, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants