Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmakepkg: .com needs to be handled as an extension for win32 executable #35

Open
nu774 opened this issue Jan 4, 2024 · 2 comments
Open

Comments

@nu774
Copy link

nu774 commented Jan 4, 2024

3077636 doesn't take care of the .com extension.
It's at least used by mpv (mpv uses both of mpv.exe and mpv.com).

@lazka
Copy link
Member

lazka commented Jan 4, 2024

Thanks, that's something we should consider when tackling #29

@nu774
Copy link
Author

nu774 commented Jan 4, 2024

BTW, you should also note that this line:

if LANG=en_US.UTF-8 LC_ALL=C objdump -f "${binary}" | grep -Eq '^start address 0x(0000000[01])?00401[0-9a-e][0-9a-e]0'

catches only x86 exe but not x64 exe.
cf. https://learn.microsoft.com/en-us/cpp/build/reference/base-base-address?view=msvc-170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants