Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpm_pkg_is_core_package: handle other msys2-runtime versions #39

Closed
lazka opened this issue Mar 31, 2024 · 0 comments · Fixed by #43
Closed

alpm_pkg_is_core_package: handle other msys2-runtime versions #39

lazka opened this issue Mar 31, 2024 · 0 comments · Fixed by #43

Comments

@lazka
Copy link
Member

lazka commented Mar 31, 2024

We currently have various msys2-runtime packages with different versions (for older Windows, 32bit etc, test versions) which currently don't get the core update treatment because we just have a hardcoded list in pacman:

strcmp(pkg->name, "bash") == 0 ||
strcmp(pkg->name, "filesystem") == 0 ||
strcmp(pkg->name, "mintty") == 0 ||
strcmp(pkg->name, "msys2-runtime") == 0 ||
strcmp(pkg->name, "msys2-runtime-devel") == 0 ||
strcmp(pkg->name, "pacman") == 0 ||
strcmp(pkg->name, "pacman-mirrors") == 0;

We should expand that to also handle "msys2-runtime-" and "msys2-runtime--devel".

lazka added a commit to lazka/msys2-pacman that referenced this issue Apr 30, 2024
@lazka lazka closed this as completed in #43 Apr 30, 2024
lazka added a commit that referenced this issue Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant