Make lint_pkgbuild opt-in via MAKEPKG_LINT_PKGBUILD=1 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cygwin bash is struggling with the thousands of commands that get invoked when lint_pkgbuild is run. This especially is annoying for split packages because the calls get multiplied by the package count. For example when running --printsrcinfo: msys/brotli (4 packages) * 39.8 seconds with linting * 7 seconds without msys/tar (1 package) * 10.2 seconds with linting * 2 seconds without This changes the default to not lint the PKGBUILD and adds a MAKEPKG_LINT_PKGBUILD env var that can be used to enable linting. We can for example enable this in CI.
|
Holy mackerel, that's faster! I assumed it was unavoidable fork delays, or I would have complained a while ago. Instant |
|
I had this lying around way too long and patching it locally.... sry.. but better late then never. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cygwin bash is struggling with the thousands of commands that get invoked when lint_pkgbuild is run. This especially is annoying for split packages because the calls get multiplied by the package count.
For example when running --printsrcinfo:
msys/brotli (4 packages)
msys/tar (1 package)
This changes the default to not lint the PKGBUILD and adds a MAKEPKG_LINT_PKGBUILD env var that can be used to enable linting. We can for example enable this in CI.