Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lint_pkgbuild opt-in via MAKEPKG_LINT_PKGBUILD=1 #18

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

lazka
Copy link
Member

@lazka lazka commented Sep 10, 2022

Cygwin bash is struggling with the thousands of commands that get invoked when lint_pkgbuild is run. This especially is annoying for split packages because the calls get multiplied by the package count.

For example when running --printsrcinfo:

msys/brotli (4 packages)

  • 39.8 seconds with linting
  • 7 seconds without

msys/tar (1 package)

  • 10.2 seconds with linting
  • 2 seconds without

This changes the default to not lint the PKGBUILD and adds a MAKEPKG_LINT_PKGBUILD env var that can be used to enable linting. We can for example enable this in CI.

Cygwin bash is struggling with the thousands of commands that get invoked
when lint_pkgbuild is run. This especially is annoying for split packages
because the calls get multiplied by the package count.

For example when running --printsrcinfo:

msys/brotli (4 packages)
* 39.8 seconds with linting
* 7 seconds without

msys/tar (1 package)
* 10.2 seconds with linting
* 2 seconds without

This changes the default to not lint the PKGBUILD and adds a
MAKEPKG_LINT_PKGBUILD env var that can be used to enable linting.
We can for example enable this in CI.
@lazka lazka mentioned this pull request Sep 10, 2022
7 tasks
@lazka lazka merged commit fa096f8 into msys2:msys2-v6.0.1 Sep 11, 2022
@cbrt64
Copy link

cbrt64 commented Sep 16, 2022

Holy mackerel, that's faster! I assumed it was unavoidable fork delays, or I would have complained a while ago. Instant makepkg startup instead of waiting ~20 s. Thank you, sir.

@lazka
Copy link
Member Author

lazka commented Sep 19, 2022

I had this lying around way too long and patching it locally.... sry.. but better late then never.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants