Skip to content

Commit

Permalink
Cygwin: fix unlink in container
Browse files Browse the repository at this point in the history
Deleting files returns STATUS_INVALID_PARAMETE on a bind mounted file system
in hyper-v container with FILE_DISPOSITION_POSIX_SEMANTICS.
Therefore fall back to default method.

This code is suggested by Johannes Schindelin on github
and I change it more simple.

Signed-off-by: Yoshinao Muramatsu <ysno@ac.auone-net.jp>
  • Loading branch information
YO4 authored and github-cygwin committed Mar 21, 2023
1 parent fe2545e commit 527dd1b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion winsup/cygwin/syscalls.cc
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,10 @@ unlink_nt (path_conv &pc, bool shareable)
/* Trying to delete in-use executables and DLLs using
FILE_DISPOSITION_POSIX_SEMANTICS returns STATUS_CANNOT_DELETE.
Fall back to the default method. */
if (status != STATUS_CANNOT_DELETE)
/* Additionaly that returns STATUS_INVALID_PARAMETER
on a bind mounted fs in hyper-v container. Falling back too. */
if (status != STATUS_CANNOT_DELETE
&& status != STATUS_INVALID_PARAMETER)
goto out;
}

Expand Down

0 comments on commit 527dd1b

Please sign in to comment.