Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add section 'context' #88

Merged
merged 1 commit into from
Nov 16, 2020
Merged

readme: add section 'context' #88

merged 1 commit into from
Nov 16, 2020

Conversation

eine
Copy link
Collaborator

@eine eine commented Nov 14, 2020

Close #83

As discussed in #83, it is currently not clear enough in the README which are the target users of this Action. I had the hope for the context to stabilise after actions/runner-images#1648 was merged. However, it was rolled back, so it will take longer until the changes to the virtual environments provided by GitHub are applied: actions/runner-images#1525.

This PR adds a 'Context' section to the README, trying to explain the current status meanwhile. Note that I'm not a native speaker, so I'd be glad to receive style suggestions.

/cc @tobiasherzke @lazka

@lazka
Copy link
Member

lazka commented Nov 15, 2020

lgtm

Copy link
Member

@jeremyd2019 jeremyd2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Reviewed-by: jeremyd2019 <github@jdrake.com>
@eine eine merged commit b4bd68c into master Nov 16, 2020
@eine eine deleted the readme/context branch November 16, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could you please clarify documentation:
3 participants