This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
forked from git-for-windows/git
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
git-show: do not segfault when showing a bad tag
When a tag points at a bad or nonexistent object, we should diagnose the breakage and exit. An earlier commit 4f3dcc2 (Fix 'git show' on signed tag of signed tag of commit, 2008-07-01) lost this check and made it segfault instead; not good. This fixes it. Signed-off-by: Junio C Hamano <gitster@pobox.com>
- Loading branch information
Showing
2 changed files
with
27 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#!/bin/sh | ||
|
||
test_description='git show' | ||
|
||
. ./test-lib.sh | ||
|
||
test_expect_success setup ' | ||
echo hello world >foo && | ||
H=$(git hash-object -w foo) && | ||
git tag -a foo-tag -m "Tags $H" $H && | ||
HH=$(expr "$H" : "\(..\)") && | ||
H38=$(expr "$H" : "..\(.*\)") && | ||
rm -f .git/objects/$HH/$H38 | ||
' | ||
|
||
test_expect_success 'showing a tag that point at a missing object' ' | ||
test_must_fail git --no-pager show foo-tag | ||
' | ||
|
||
test_done |