wincred credential helper doesn't work when e-mail used as a user name

[AlexeyKryshen]

For some reason if e-mail used as a username (I was working with Github, unfortunately have no other repos to test) wincred doesn't work: while credentials are stored in Windows, git continue to ask credentials. In order to get the wincred helper work for Github I have to use the my normal Github username, not e-mail. Maybe there is problem with multiple '@' symbols in URL used if e-mail is used as username ? Because credentials are actually stored but not used, it seems that key used to store credential and one used to retrieve are different for some reason (escaped/not escaped '@' ?)

[kusma]

Yeah, this happened in @kblees' Windows XP fix, as I already pointed out here: https://groups.google.com/d/msg/msysgit/YVuCqmwwRyY/HULHj5OoE88J

I wonder if reverting it is the sane thing to do, as Windows XP is EOL...

[kusma]

By the way, your speculation is entirely correct, multiple '@' symbols makes the credential-helper mess up. I guess some proper encoding is needed, unless we're going back to using attributes to store these things.

[AlexeyKryshen]

Not sure, but I think that URL-encoding of user name (which are e-mail) could help ? '@' will be replaced with '%40' in e-mail-as-username part, so there are will be single normal '@'-delimiter in string representation of credential line? And URL itself is still will be valid, of course.

Could this solve the problem ?

[kusma]

Yeah, that would solve the problem. Patches welcome.

[linquize]

Did you test with https://github.com/git-for-windows/git 2.4?

[huerlisi]

I just tested on the newest git-for-windows release candidate. Still not working.

[huerlisi]

Sorry, it actually worked!

👍

[dscho]

@huerlisi please feel free to close tickets yourself when the associated problems are addressed.

[rofrol]

wincred doesn't work for me. Works with %40 and store

 git config --global credential.helper store

[CrescentFresh]

Running TG 2.4.0.2, still can't use my email as my username, I keep getting prompted.

Switch to my username that does not include @, and works as expected.

[dscho]

The msysGit project is unmaintained since Git for Windows 2.5.0 was released. If you have questions or bug reports that are not Windows-specific, it would be better to report them to the Git mailing list instead.