Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and support telemetry #120

Merged
merged 2 commits into from
Jul 24, 2022
Merged

Add and support telemetry #120

merged 2 commits into from
Jul 24, 2022

Conversation

SophisticaSean
Copy link
Contributor

No description provided.

@SophisticaSean
Copy link
Contributor Author

This work is confirmed working in production for the last ~1 year. This allows you to see where/what hammox is spending time on while you're testing.

Example flame graph with Datadog and Spandex:
hammox-tracing

This helps users understand the performance implications of Hammox and wire up any flavor of tracing/reporting for hammox.

@SophisticaSean
Copy link
Contributor Author

@msz any movement on this? I've made all your recommended changes as per #103

@msz msz self-requested a review June 30, 2022 16:24
Copy link
Owner

@msz msz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I love the detailed guide especially. Feel free to apply my suggestion or not, and I'll merge

end
end

defmodule Hammox.Telemetry.TelemetryEnabled do
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
defmodule Hammox.Telemetry.TelemetryEnabled do
defmodule Hammox.Telemetry.ErlangTelemetry do

@msz msz merged commit f04817a into msz:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants