Use case-insenstive string comparison for team org ownership #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
reviewed
Feb 9, 2022
internal/check/valid_owner.go
Outdated
| @@ -180,8 +180,8 @@ func (v *ValidOwner) validateTeam(ctx context.Context, name string) *validateErr | |||
| org = strings.TrimPrefix(org, "@") | |||
| team := parts[1] | |||
|
|
|||
| if org != v.orgName { | |||
| return newValidateError("Team %q does not belongs to %q organization.", team, v.orgName) | |||
| if !strings.EqualFold(org, v.orgName) { | |||
There was a problem hiding this comment.
it's already done in line 176 (name = strings.ToLower(name)) but I need to double-check whether GitHub still does it as someone pointed out that it was changed: #78 (comment)
mszostok
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an org name has any capital letters, the normalized team org name will not match the org name.
For instance: an org named
Acmewith team@Acme/developmentwill end up comparingacme(org) toAcme(v.orgName).Changes proposed in this pull request:
belongstobelongin error message.