Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle internal err, report issue with empty CODEOWNERS or git dirty state #130

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

mszostok
Copy link
Owner

Description

Changes proposed in this pull request:

  • Handle internal checks errors
    Previously they were only logged, now there are printed to check results and proper exit code is also set.
    Instead of:

    time="2022-02-27T09:21:01Z" level=error msg="while executing checker [Experimental] Not Owned File Checker: 1 error occurred:\n\t* fatal: No pathspec was given. Which files should I remove?\n: command \"xargs\": exit status 123\n\n" service="check:runner"
    

    We have:

    ==> Executing [Experimental] Not Owned File Checker (23.312587ms)
        [Internal Error] No pathspec was given. Which files should I remove?\n: command \"xargs\": exit status 123
    
    1 check(s) executed, 1 failure(s)
    exit status 3
    
  • Report issue with empty CODEOWNERS

    ==> Executing [Experimental] Not Owned File Checker (23.312587ms)
        [err] The CODEOWNERS file is empty. The files in the repository don't have any owner.
    
    1 check(s) executed, 1 failure(s)
    exit status 3
    
  • Report or git dirty state

    ==> Executing [Experimental] Not Owned File Checker (23.312587ms)
        [err] git state is dirty: commit all changes before executing this check
    
    1 check(s) executed, 1 failure(s)
    exit status 3
    

Related issue(s)

Fix #126

@mszostok mszostok added the enhancement New feature or request label Mar 12, 2022
@mszostok mszostok merged commit d7b92b1 into main Mar 12, 2022
@mszostok mszostok deleted the internal-err-handling branch March 12, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notowned with an empty codeowners file
1 participant