Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add spacing around pipe operator #39

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

rmax
Copy link
Contributor

@rmax rmax commented May 19, 2020

Description

Changes proposed in this pull request:

  • This fixes the experience for zsh users where copy pasting http://foo| bar escapes the pipe as http://foo\| bar.

This fixes the experience for zsh users where copy pasting `foo| bar` escapes the pipe as `foo\| bar`.
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           2        2           
  Lines          48       48           
=======================================
  Hits           40       40           
  Misses          7        7           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1951ba8...2dfd520. Read the comment docs.

@rmax
Copy link
Contributor Author

rmax commented May 19, 2020

Integration tests failed due to GH api rate limit :(

@mszostok
Copy link
Owner

Hi @rmax
Thanks for your PR! 🙂

I'm checking that issue and will merge your pr once I will resolve it ;)

@mszostok
Copy link
Owner

mszostok commented May 19, 2020

ok, the problem is related to Travis itself:

Encrypted environment variables have been removed for security reasons.

so token was removed from the integration tests.

https://docs.travis-ci.com/user/pull-requests#pull-requests-and-security-restrictions

I will work on that separately. Anyway thanks for your PR :)

@mszostok mszostok merged commit 8db939c into mszostok:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants