Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for finding duplicated patterns, refactor issue printing #5

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

mszostok
Copy link
Owner

@mszostok mszostok commented Nov 1, 2019

  • Make line number in Issue entry as optional. Print it only when defined
  • Document release process
  • Add check for finding duplicated patterns, refactor issue printing

Example output in case of finding duplicated patterns

==> Executing Duplicated Pattern Checker (1.337127ms)
    [err] Pattern "/resources/awesome-folder/" is defined 2 times in lines:
            * 168: with owners: [@derberg @pbochynski @PK85 @a-thaler @Abd4llA]
            * 171: with owners: [@aszecowka @PK85 @mszostok @adamwalach]

@mszostok mszostok force-pushed the myk-dup-pattern branch 5 times, most recently from 9d5bd0c to d40e640 Compare November 5, 2019 17:20
- Make line number in Issue entry as optional. Print it only when defined
- Document release process

Example output in case of fininding duplicated patterns

```
==> Executing Duplicated Pattern Checker (1.337127ms)
    [err] Pattern "/resources/awesome-folder/" is defined 2 times in lines:
            * 168: with owners: [@derberg @pbochynski @PK85 @a-thaler @Abd4llA]
            * 171: with owners: [@aszecowka @PK85 @mszostok @adamwalach]
```
@mszostok mszostok merged commit f186bd8 into master Nov 5, 2019
@mszostok mszostok deleted the myk-dup-pattern branch November 12, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant