Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify player if whispers cant be heard by anyone #13

Closed
S-S-X opened this issue May 25, 2020 · 4 comments · Fixed by #21
Closed

Notify player if whispers cant be heard by anyone #13

S-S-X opened this issue May 25, 2020 · 4 comments · Fixed by #21
Labels
enhancement New feature or request

Comments

@S-S-X
Copy link
Member

S-S-X commented May 25, 2020

Count players that received message and if count is less than 1 then send some chat message back to whisperer telling that nobody could heard their whispers.

@S-S-X S-S-X added the enhancement New feature or request label May 25, 2020
@S-S-X
Copy link
Member Author

S-S-X commented May 25, 2020

Opening this again, sorry for misleading description but there must be at least 2 players hearing whisper: whisperer and other player.

@S-S-X S-S-X reopened this May 25, 2020
@S-S-X
Copy link
Member Author

S-S-X commented May 25, 2020

Also, please do not check if whispering player is other_player because that will hide actual message from player who sent message, instead either count or add success if player != other_player.

@BuckarooBanzay
Copy link
Member

Opening this again, sorry for misleading description but there must be at least 2 players hearing whisper: whisperer and other player.

Thanks for pointing that out 👍

Also, please do not check if whispering player is other_player because that will hide actual message from player who sent message, instead either count or add success if player != other_player.

That would have been my first solution 😋

@S-S-X
Copy link
Member Author

S-S-X commented Aug 21, 2020

This is not working correctly because returning error message does not seem to be working, has to actually send message using mt api.

@S-S-X S-S-X reopened this Aug 21, 2020
S-S-X pushed a commit that referenced this issue Aug 21, 2020
@S-S-X S-S-X closed this as completed in #21 Aug 21, 2020
S-S-X added a commit that referenced this issue Aug 21, 2020
#13 Fix whisper feedback message sending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants