Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle interactions w/ explosions #3

Merged
merged 7 commits into from Oct 3, 2023
Merged

handle interactions w/ explosions #3

merged 7 commits into from Oct 3, 2023

Conversation

fluxionary
Copy link
Member

this was originally pyrollo#50

  1. sign entities shouldn't be destroyed by explosions if the sign isn't destroyed
  2. sign entities (and node metadata) should be removed if the sign is destroyed by an explosion.

wsor4035
wsor4035 reviewed Jul 29, 2023
View reviewed changes
Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial thoughts

display_api/display.lua Outdated Show resolved Hide resolved
display_api/display.lua Outdated Show resolved Hide resolved
@fluxionary
Copy link
Member Author

i'll get back to this at some point, it's on the todo list

@Niklp09
Copy link
Member

Niklp09 commented Sep 13, 2023

@fluxionary Can we merge this?

@Niklp09 Niklp09 requested a review from wsor4035 October 2, 2023 15:45
@Niklp09 Niklp09 merged commit 2c1efed into master Oct 3, 2023
2 checks passed
@Niklp09 Niklp09 deleted the boom branch October 3, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes

@wsor4035 wsor4035 Awaiting requested review from wsor4035

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fluxionary @Niklp09 @wsor4035 @BuckarooBanzay