Fix sign formspec updates while used

[Niklp09]

Please read https://gitea.your-land.de/your-land/bugtracker/issues/5553

EDIT(wsor - lazy and tired of opening the link above, this from flux):
i figured out why i could't replicate this locally initially - it only happens when using the mt-mods fork of display_modpack, not the pyrollo fork. i've traced it to this commit: 1f8e99c9c5

the issue is that when a player is looking at a node formspec, and the node formspec is modified, what the player sees is also modified. but looking at that commit above, right-clicking the sign should only modify the formspec if it needs to have that fix applied. however, i'm having this issue multiple times on certain signs, and also for new signs that were placed well after the fix was applied. something else might be modifying the sign formspec, perhaps...

[wsor4035]

why not just remove the on rightclick and let it update on save rather than having an lbm run for all eternity? unless im missing something here

[fluxionary]

why not just remove the on rightclick and let it update on save rather than having an lbm run for all eternity? unless im missing something here

run_at_every_load = false. the impact of the LBM will be minimal.

[wsor4035]

looks good, didnt test

[OgelGames]

I see no reason to add a LBM, there isn't anything that needs updating before the formspec is opened. Just removing the on_rightclick should be enough to fix this.

[wsor4035]

I see no reason to add a LBM, there isn't anything that needs updating before the formspec is opened. Just removing the on_rightclick should be enough to fix this.

while i agree, reading this, the lbm in theory updates it before the user opens it(applying the formspec escape), rather than closing it, so the issue is solved before hand