use canonical_name if it is available; report error when recipients don't exist #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd mail to non-existent players
|
i think i ninja'd you there :/ |
sounds good, will close this then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main aim of this PR was to make use of my canonical_name mod if possible. canonical_name corrects mis-capitalized user names. if canonical_name is installed, sending mail to "FlUX" will correctly be delivered to "flux", instead of ending up in limbo.
i also added a basic feature where a sender is alerted w/ a chat message if one or more of the recipients does not exist.