Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divorce biome lib and cleanup code #11

Merged
merged 18 commits into from Oct 24, 2022
Merged

Divorce biome lib and cleanup code #11

merged 18 commits into from Oct 24, 2022

Conversation

wsor4035
Copy link
Contributor

@wsor4035 wsor4035 commented Jul 1, 2022

see the title

  • get rid of biome lib
  • fix .luacheckrc
  • add github action for luacheck
  • replace global settings with settings api
  • replace default_settings.txt file with descriptions in settings api
  • fix various luacheck warnings
  • profit?

fixes #9

@wsor4035 wsor4035 added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 1, 2022
@wsor4035
Copy link
Contributor Author

wsor4035 commented Jul 1, 2022

note: this will need backwards compat testing to make sure nothing crashes on old worlds with this PR

@wsor4035
Copy link
Contributor Author

wsor4035 commented Jul 2, 2022

tree generation does now work, note that it is laggy as all get out due to way to many trees being placed and spawning, uncomment the set node stone and that will keep them from spawning to play with placement values

@ghost
Copy link

ghost commented Aug 20, 2022

Might be nice to go away with biomelib. I might try to port this to work with mineclone 2, but I dont know if I will for sure.

@wsor4035
Copy link
Contributor Author

Might be nice to go away with biomelib

more like required, given how terrible its perf is

I might try to port this to work with mineclone 2

make a pr, be glad to make this game agnostic.

above said, i do need to finish this....

@BuckarooBanzay
Copy link
Member

LGTM 👍 (ingame is not better or worse than before 😉)

Copy link
Member

@Niklp09 Niklp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, wsor! I've added some comments where you can make optimizations

init.lua Show resolved Hide resolved
mod.conf Show resolved Hide resolved
Copy link
Member

@Niklp09 Niklp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested a bit ingame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moretrees without biome lib
3 participants