New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divorce biome lib and cleanup code #11
Conversation
note: this will need backwards compat testing to make sure nothing crashes on old worlds with this PR |
tree generation does now work, note that it is laggy as all get out due to way to many trees being placed and spawning, uncomment the set node stone and that will keep them from spawning to play with placement values |
Might be nice to go away with biomelib. I might try to port this to work with mineclone 2, but I dont know if I will for sure. |
more like required, given how terrible its perf is
make a pr, be glad to make this game agnostic. above said, i do need to finish this.... |
LGTM 👍 (ingame is not better or worse than before 😉) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, wsor! I've added some comments where you can make optimizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested a bit ingame
see the title
fixes #9