Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vines: Variables missing local keyword #13

Merged
merged 1 commit into from Dec 28, 2021
Merged

Vines: Variables missing local keyword #13

merged 1 commit into from Dec 28, 2021

Conversation

JordanL2
Copy link
Contributor

@JordanL2 JordanL2 commented Dec 27, 2021

In the vines mod:

  1. Some variables were missing local keyword
  2. The recipes for the rope block were being registered even if ropes are disabled
  3. Some code reorganisation and comments to more clearly label sections

@JordanL2 JordanL2 changed the title Variables missing local keyword Vines: Variables missing local keyword Dec 27, 2021
@OgelGames
Copy link
Contributor

LGTM 👍

@JordanL2
Copy link
Contributor Author

JordanL2 commented Dec 27, 2021

@OgelGames since your PR fixes the missing locals, should I remove those changes from this PR? Or just sort it out when one of the PRs is merged?

@wsor4035
Copy link
Contributor

do we really need * VINES comments adding three lines? seems the variables names are self explanatory.

if needed, i suggest

end

--comment
if xyz then

1. Some variables were missing local keyword
2. The recipes for the rope block were being registered even if ropes are disabled
3. Some code reorganisation and comments to more clearly label sections
@JordanL2
Copy link
Contributor Author

The comments make it somewhat easier to find a particular vine type quickly, but the whitespace is a bit excessive I agree. Commit made to reduce it.

@OgelGames
Copy link
Contributor

@OgelGames since your PR fixes the missing locals, should I remove those changes from this PR? Or just sort it out when one of the PRs is merged?

I'll sort it out after this PR is merged ;)

@OgelGames OgelGames merged commit 7094d8a into mt-mods:master Dec 28, 2021
@JordanL2 JordanL2 deleted the global_fixes branch December 28, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants