-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Off/On button in sign formspec is not translatable #20
Comments
if im thinking of the proper toggle, its also used in pipeworks, etc and is a massive hack in terms of implementation |
Maybe tooltip could be used for accessibility and on/off text changed to some symbol. |
You could also just use good old checkboxes. Anyway, it's not really important for me. |
Yeah, that's the one, and yeah, it's horrible :P
This is probably the cleanest solution, not requiring much code or texture changes 👍 |
what's wrong with good old checkboxes? Edit: I mean, they are standardized, players know what they look like and how they work, why introduce yet another element the user needs to learn about? |
OK, tiny checkboxes on huge screens aren't easy to use. So why not issue a change in core so all checkboxes get 'fixed'? |
It can be added as an issue, but it is beyond my abilities to fix in source C which is where Im guessing the fix would be needed? Given most users are Im guessing still using HD vs UHD I dont think it would get a quick fix label but might get addressed as the coredevs work through those issues. Guess it comes down to how fast and bad is this issue for sign_lib if its not a big deal probably just need to cross link the above issue and note it here as wont be fixed until Engine bug is addressed. (I'll go have a skim and see if its been reported yet) Im more of address what you can in your own mod kind of guy but understand the other approach as well as it lowers number of changes for mods which for low grade bugs/issues is a better way to go, particularly were resources are limited. Anyways the image CB fix is trivial (full working on my machine) the formspec fix is less trivial assuming no duplication of old formspec fields needed I have that about 90% done. if it's easier I can post both sets of code here + in the case of the first fake cb's images as well and then a decscion can be made about which way to go? Just let me know in a reply here :) Edit: |
(I don't even have HD) |
Didn't take long. Please test with a build after this commit: minetest/minetest#13666 (comment) |
Yes Smalljoker picked it up which was great :) Edit: had a hunt around and cant find a build that includes the fix yet, so ill wait a couple of days then give it another try. |
@sirrobzeroone - I've added your checkboxes to my own fork of signs_lib if you wanna test it. |
But it would make sense to get as much features/fixes upstream as possible. |
@Niklp09 - Of course! but it doesn't hurt to have a test edition to try out features on first :) |
There are 2 on/off buttons in the sign formspec, one for wide font, the other for Unicode font.
The problem is, these buttons have the text "OFF" and "ON" baked into the images, making them untranslatable.
I would like it if there buttons would be replaced with something that does not have text baked into the image.
The text was updated successfully, but these errors were encountered: