Checkboxes are too small in 4K/UHD

[sirrobzeroone]

Minetest version

5.7 Stable

OS / Hardware

Operating system: Win10
Screen UHD: 3840x2160p
OS Forces scaling to 200% but I force set this to100% but ended up with tinier out of scale checkboxes

Summary

Affects both MT main menu and formspec. Checkboxes are rendered about 50% to small when using UHD res - assuming standard of checkboxs should be about the same hieght as text.

Steps to reproduce

Open MT on a UHD device on Win10, Creative mode, Enable Damage, Host server appear small:

Edit: Thought a more actual size image could help illustrate:

Add Checkbox as formspec elment and they are likewise smaller than expected:

[SmallJoker]

This is an issue in upstream Irrlicht as well: https://sourceforge.net/p/irrlicht/code/HEAD/tree/trunk/source/Irrlicht/CGUICheckBox.cpp#l149

This should either be fixed in upstream Irrlicht or in IrrlichtMt:

https://github.com/minetest/irrlicht/blob/b249e4523d9e0b8d7e607131685de34d8c48cd6b/source/Irrlicht/CGUICheckBox.cpp#L147

[sfan5]

Easy reproducer:
./bin/minetest --config <(echo gui_scaling=0.5)

[SmallJoker]

Correction. This is fixable in Minetest because Irrlicht skins can be created and modified:

minetest/src/client/clientlauncher.cpp

Lines 147 to 149 in 2061984

	#ifdef HAVE_TOUCHSCREENGUI
	float density = RenderingEngine::getDisplayDensity();
	skin->setSize(gui::EGDS_CHECK_BOX_WIDTH, (s32)(17.0f * density));

It should be easy to adapt this factor to make use of the display density for non-touchscreens as well.

[sfan5]

Manually adjusting some sizes looks like a hack to be honest, the GUI should be able to work with the sizes it is given.

[rubenwardy]

We maintain our own Irrlicht now, if the fix is better done in irrlichtmt it should be done there