Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sign entity if sign is gone (due to voxelmanip or such) #9

Merged
merged 1 commit into from May 10, 2022
Merged

remove sign entity if sign is gone (due to voxelmanip or such) #9

merged 1 commit into from May 10, 2022

Conversation

fluxionary
Copy link
Member

fixes #8

S-S-X
S-S-X approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@S-S-X S-S-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but LGTM.

If it would be just worldedit problem I'd say player who is using worldedit should also clear objects (or worldedit should do it for you) but this is also problem with other mods so I guess workaround is good anyway.

@wsor4035 wsor4035 merged commit 4dbfbec into master May 10, 2022
@wsor4035 wsor4035 deleted the entity_gc branch May 10, 2022 23:47
@parnikkapore
Copy link

This seems to assume that all sign nodes are in the sign group. Which, uhh, basic_signs#1

@fluxionary
Copy link
Member Author

fluxionary commented May 11, 2022 •
edited

This seems to assume that all sign nodes are in the sign group. Which, uhh, basic_signs#1

Signs get added to the sign group in signs_lib:register_sign. Some other logic in signs_lib already assumes all signs are in that group.

EDIT: Whoops apparently I'm wrong :\

@parnikkapore
Copy link

Yea, I also thought that this is the case, but couldn't find such a code.

@fluxionary
Copy link
Member Author

I'll make a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsor4035 wsor4035 wsor4035 approved these changes

@S-S-X S-S-X S-S-X approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign entities stick around weirdly if signs are removed via voxelmanip
4 participants
@fluxionary @parnikkapore @wsor4035 @S-S-X