MineClone/MineClonia compatibility for technic core

[nonfreegithub]

• sounds
• dig groups
• mcl_blast_resistance
• mcl_hardness
• crafts
• formspec
• recipes
• mcl_craftguide support

[corarona]

very nice, tested a bit, seems to work well so far

[corarona]

One possible issue: HV-quarry can dig bedrock ... and void

[corarona]

[S-S-X]

Have to add sounds to fixtures for tests, I can also add that if you want?

[S-S-X]

how can I fix the lua check failed?

Luacheck is passing, just mineunit failing. That's exactly what requires sounds to mineunit fixtures, I'll see where it should be added, check if anything else is needed and hopefully add commit to fix tests shortly.

[nonfreegithub]

I ran into an issue: there is no way to get a low voltage transformer: making it requires technic:rubber (replacement for fiber), but to make technic:rubber requires coal dust, which requires a grinding, which requires lv power, which requires a switching station, which requires a low voltage transformer again.

fixed

Alternatively, a more expensive (or less efficient) alloy recipe could be added, such as 2x latex + 1x coal lump = 2x rubber.

alloy recipe added

[BuckarooBanzay]

@OgelGames you self-requested a review, do you need more time (no pressure:) to look at this or can we get this merged and sort out potential issues later? (looked good last time i tested it)

[S-S-X]

@OgelGames you self-requested a review, do you need more time (no pressure:) to look at this or can we get this merged and sort out potential issues later? (looked good last time i tested it)

I got few change requests but most of it already good and will approve after luacheck fix and tools/init.lua reset.

[S-S-X]

change request requires comment, just adding to make it clear

[OgelGames]

@OgelGames you self-requested a review, do you need more time (no pressure:) to look at this or can we get this merged and sort out potential issues later? (looked good last time i tested it)

Yeah, I wanted to look over all the code one more time, because I've missed a lot of the commits. I also wanted to test it a bit. I know it's probably fine, but with such a big PR, it's good to triple check it :)

[S-S-X]

LGTM but have not actually tested in game. Currently it focuses pretty well on MCL compatibility while still keeping changes fairly simple and clear 👍

[BuckarooBanzay]

i resolved some conflicts from the merged PR in the master branch, ignore the mtinfo workflow error when merging, will remove that feature in another PR i think (it caused more trouble than it is worth)

[nonfreegithub]

why the check fail?

[BuckarooBanzay]

why the check fail?

don't worry about the mtinfo check, it currently fails because the test still uses the 5.3.0 docker image which doesn't have the vector.zero() function

[BuckarooBanzay]

i don't see anything blocking this PR anymore, all comments are resolved and we have 3 approvals, will test this one more time and merge within one or 2 days if there are no objections (cleanups and minor fixes can be done in a separate PR)