-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MineClone/MineClonia compatibility for technic core #328
Conversation
nonfreegithub
commented
Sep 30, 2023
•
edited
Loading
edited
- sounds
- dig groups
- mcl_blast_resistance
- mcl_hardness
- crafts
- formspec
- recipes
- mcl_craftguide support
very nice, tested a bit, seems to work well so far |
One possible issue: HV-quarry can dig bedrock ... and void |
Have to add sounds to fixtures for tests, I can also add that if you want? |
- mcl_core:bedrock - mcl_core:barrier - df_underworld_items:slade - df_underworld_items:slade_brick - df_underworld_items:slade_wall - df_underworld_items:slade_sand - df_underworld_items:slade_block - df_underworld_items:slade_seal
Luacheck is passing, just mineunit failing. That's exactly what requires sounds to mineunit fixtures, I'll see where it should be added, check if anything else is needed and hopefully add commit to fix tests shortly. |
fixed
alloy recipe added |
@OgelGames you self-requested a review, do you need more time (no pressure:) to look at this or can we get this merged and sort out potential issues later? (looked good last time i tested it) |
I got few change requests but most of it already good and will approve after luacheck fix and tools/init.lua reset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change request requires comment, just adding to make it clear
Yeah, I wanted to look over all the code one more time, because I've missed a lot of the commits. I also wanted to test it a bit. I know it's probably fine, but with such a big PR, it's good to triple check it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but have not actually tested in game. Currently it focuses pretty well on MCL compatibility while still keeping changes fairly simple and clear 👍
i resolved some conflicts from the merged PR in the master branch, ignore the |
why the check fail? |
don't worry about the |
i don't see anything blocking this PR anymore, all comments are resolved and we have 3 approvals, will test this one more time and merge within one or 2 days if there are no objections (cleanups and minor fixes can be done in a separate PR) |