fix logic of unifieddyes.on_dig to conform w/ documentation #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, there's logic errors in
unifieddyes.on_dig
. per the documentation,currently, that function sometimes returns
nil
on failure, sometimes returnsnil
on success, and sometimes returns the value ofminetest.dig_node
. this breaks some code i'm writing for my replacer redo, which attempts to not allow the replacer to change the colors of nodes. it also fails to do the other things thatminetest.dig_node
does, e.g. wear out the tool and call various callbacks.in this PR, i've copied out the code for
minetest.node_dig
into a separate function that differs only in that it doesn't ask the lua API to generate the drops, and instead just uses the item without thepalette_index
metadata.