-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dig rate limiter #48
Dig rate limiter #48
Conversation
Should configuration value be XP / second instead of direct rate limiter parameter? |
Well, not easy enough for me to add XP / second so it is XP additions / second. And now line too long for luacheck.. |
pls squash if merging this pile |
nice work 👍 |
I think higher values would be okay to keep some variation, for sure setting to 2-3 would reduce sand digging as it would be about same XP no matter what you'd be digging. Sand digging can easily give 16 XP / second with high level tools. Added bamboo and papyrus dig limits are not that easy to predict as I think recursion was limited based on player position, not digged node position. I think something between 15 - 20 could work well enough, I would rather keep limit high at first and maybe bring it down if it seems that it would be somehow useful. |
Yeah, I think it would be unfair to limit it too much, especially with the fast digging tools we have. From my testing, the fastest one can dig stone is about 19 nodes/second (max level lava multitool), and the fastest for sand is about 27 n/s. So I think a limit of 20 is probably about right, as it limits XP from sand digging and other fast-digging nodes, but not regular mining. |
as long as my tool still digs at it's level :) |
pandorabox-io/pandorabox.io#611
By default digging rate is not limited.