Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dig rate limiter #48

Merged
merged 6 commits into from
Feb 7, 2021
Merged

Dig rate limiter #48

merged 6 commits into from
Feb 7, 2021

Conversation

S-S-X
Copy link
Member

@S-S-X S-S-X commented Feb 6, 2021

pandorabox-io/pandorabox.io#611

  • some general client side cheat mitigation.

By default digging rate is not limited.

@S-S-X S-S-X added the enhancement New feature or request label Feb 6, 2021
@S-S-X
Copy link
Member Author

S-S-X commented Feb 6, 2021

Should configuration value be XP / second instead of direct rate limiter parameter?
I think that would probably be better.

@S-S-X
Copy link
Member Author

S-S-X commented Feb 6, 2021

Well, not easy enough for me to add XP / second so it is XP additions / second. And now line too long for luacheck..

@S-S-X
Copy link
Member Author

S-S-X commented Feb 6, 2021

pls squash if merging this pile

@BuckarooBanzay
Copy link
Member

nice work 👍
any recommendations for the xp.limit_dig_rate setting? i'm thinking 2 or 3 should be a sane value, we might even have to adjust the xp-priv thresholds afterwards to keep is somewhat fair...

@BuckarooBanzay BuckarooBanzay merged commit 78a8e0a into master Feb 7, 2021
@S-S-X
Copy link
Member Author

S-S-X commented Feb 7, 2021

any recommendations for the xp.limit_dig_rate setting? i'm thinking 2 or 3 should be a sane value, we might even have to adjust the xp-priv thresholds afterwards to keep is somewhat fair...

I think higher values would be okay to keep some variation, for sure setting to 2-3 would reduce sand digging as it would be about same XP no matter what you'd be digging. Sand digging can easily give 16 XP / second with high level tools.

Added bamboo and papyrus dig limits are not that easy to predict as I think recursion was limited based on player position, not digged node position.

I think something between 15 - 20 could work well enough, I would rather keep limit high at first and maybe bring it down if it seems that it would be somehow useful.

@OgelGames
Copy link
Contributor

Yeah, I think it would be unfair to limit it too much, especially with the fast digging tools we have. From my testing, the fastest one can dig stone is about 19 nodes/second (max level lava multitool), and the fastest for sand is about 27 n/s.

So I think a limit of 20 is probably about right, as it limits XP from sand digging and other fast-digging nodes, but not regular mining.

@BuckarooBanzay
Copy link
Member

done 👍 pandorabox-io/pandorabox.io@c2ac04e

@BuckarooBanzay BuckarooBanzay deleted the dig-rate-limiter branch February 8, 2021 06:44
@SwissalpS
Copy link
Contributor

as long as my tool still digs at it's level :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants