Don't output to Output Panel when setting is enabled.

mt40 · Aug 5, 2017 · 2f83a30 · 2f83a30
1 parent 56024ac
commit 2f83a30
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.9.1
+- Fix issue 68: the extension still outputs to Output Panel when the setting `showInProblems` is enabled.
+
 ## 1.9.0
 - Add option to show TODOs in PROBLEMS panel of VSCode instead. (from #65)
 - When reading, does not reject all files in batch whenever a file failed to load. (from #66)

diff --git a/built_packages/vscode-todo-parser-1.9.1.vsix b/built_packages/vscode-todo-parser-1.9.1.vsix
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "vscode-todo-parser",
   "displayName": "TODO Parser",
   "description": "Parse TODOs in your working files.",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "publisher": "minhthai",
   "engines": {
     "vscode": "^1.2.0"
@@ -51,7 +51,10 @@
               "type": "array",
               "description": "An array of words that signal the start of TODOs, or tuples containig the words and their priorities.",
               "items": {
-                "type": ["string", "array"],
+                "type": [
+                  "string",
+                  "array"
+                ],
                 "description": "Word that signals the start of a TODO comment, or a tuple of the word and comment priority.",
                 "items": [
                   {
@@ -60,10 +63,14 @@
                   },
                   {
                     "enum": [
-                      "Error", 0,
-                      "Warning", 1,
-                      "Information", 2,
-                      "Hint", 3
+                      "Error",
+                      0,
+                      "Warning",
+                      1,
+                      "Information",
+                      2,
+                      "Hint",
+                      3
                     ],
                     "description": "The priority level of the TODO comment. Determines how the TODO item is rendered in the Problems panel"
                   }
@@ -91,6 +98,7 @@
   "dependencies": {
     "chance": "^1.0.4",
     "fs-extra": "^0.30.0",
+    "typescript": "^1.8.10",
     "typescript-collections": "^1.1.2"
   },
   "license": "SEE LICENSE IN LICENSE"

diff --git a/src/classes/OutputWriter.ts b/src/classes/OutputWriter.ts
@@ -40,13 +40,17 @@ export class OutputWriter {
   static finish(todoCount: number) {
     assert(OutputWriter.state === State.Busy, "There is no work to finish.");
 
+    const showInProblems = UserSettings.getInstance().ShowInProblems.getValue();
+
     let channel = OutputWriter.outputChannel;    
-    if (todoCount == 0)
-      channel.appendLine('No TODOs found.');
-    else {
-      channel.appendLine('==================================');
-      let unit = (todoCount > 1) ? 'TODOs' : 'TODO';
-      channel.appendLine(`Found ${todoCount} ${unit}.\n`);
+    if(!showInProblems) {
+      if (todoCount == 0)
+        channel.appendLine('No TODOs found.');
+      else {
+        channel.appendLine('==================================');
+        let unit = (todoCount > 1) ? 'TODOs' : 'TODO';
+        channel.appendLine(`Found ${todoCount} ${unit}.\n`);
+      }
     }
 
     OutputWriter.state = State.Idle;
@@ -104,8 +108,10 @@ export class OutputWriter {
   }
 
   private static showPanel() {
+    const showInProblems = UserSettings.getInstance().ShowInProblems.getValue();
     let channel = OutputWriter.outputChannel;
-    if(OutputWriter.state === State.Idle) {
+
+    if(!showInProblems && OutputWriter.state === State.Idle) {
       channel.clear();
       channel.show(true);
     }