Skip to content

Commit

Permalink
Project#envvar method naming fix
Browse files Browse the repository at this point in the history
* Fix from plural envvar to envvars for consistency with API endpoint
* Preserve old functionality
  • Loading branch information
mtchavez committed Jul 25, 2016
1 parent 4162161 commit d9a5a20
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
11 changes: 10 additions & 1 deletion lib/circleci/project.rb
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,19 @@ def self.enable(username, project)
# @param project [String] - Name of project
# @return [CircleCi::Response] - Response object

def self.envvars(username, project)
def self.envvar(username, project)
CircleCi.http.get "/project/#{username}/#{project}/envvar"
end

##
#
# @deprecated Please use [CircleCi::Project#envvar]
def self.envvars(username, project)
logger = Logger.new(STDOUT)
logger.warn('[Deprecated] Project#envvars is deprecated please use Project#envvar')
envvar username, project
end

##
#
# Sets an envvar for a project
Expand Down
10 changes: 7 additions & 3 deletions spec/circleci/project_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,9 @@
end
end

describe 'envvars' do
describe 'envvar' do
context 'successfully', vcr: { cassette_name: 'project/envvar/success', record: :none } do
let(:res) { CircleCi::Project.envvars 'mtchavez', 'circleci' }
let(:res) { CircleCi::Project.envvar 'mtchavez', 'circleci' }

it 'returns a response object' do
res.should be_an_instance_of(CircleCi::Response)
Expand All @@ -420,7 +420,7 @@
end

context 'unsuccessfully', vcr: { cassette_name: 'project/envvar/unsuccessfully', record: :none } do
let(:res) { CircleCi::Project.envvars 'mtchavez', 'asdf-bogus' }
let(:res) { CircleCi::Project.envvar 'mtchavez', 'asdf-bogus' }
let(:message) { 'Project not found' }

it 'returns a response object' do
Expand All @@ -433,6 +433,10 @@
res.body['message'].should eql message
end
end

context 'envvars deprecation' do
# TODO: Fill this in
end
end

describe 'set_envvar' do
Expand Down

0 comments on commit d9a5a20

Please sign in to comment.