Update to support v1.1 api #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 13, 2016 22:04
Removes `tests` method from CircleCi::Build and adds `ssh-users` method to hit ssh-users POST request.
Adds CircleCi::Envvar ImmutableStruct (new gem dependency here) Fixes bugs found in CircleCi::Project
… tests) as these responses are requiring login.
…d is now a default dependency.
|
Thanks for working on updating the gem for the new version of the CircleCI API. These changes are a little too invasive and will be a breaking update for previous versions. I had been meaning to get to cleaning up some of the classes since more configuration has been added over the years and it is getting a little dirty. I made a first pass at doing that in #85. The refactor in that pull request keeps existing functionality working and logs out deprecation warnings to preserve a better transition for people updating. Using those base of changes I think adding in the new API versioning will be a little cleaner, hopefully. Going to close this one out unfortunately. Will get to the new version of the API soon. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates to support Circle's v1.1 API. I also change the style a little such that the Project and Build objects are initialized and have instance methods instead of containing all static methods. This hopefully reduces the redundancy of passing the
vcs_type,username,project_nameand/orbuild_numparameters.Verify
The specs have been updated to use the new style of Project and Build objects. I've marked some tests as pending as I'm getting "you must log in" responses that I believe are caused because the Circle TOKEN env variable needs to be updated.
I also will work on updating the README to give examples of new design, but wanted to open the PR and see if you'd be willing to merge this as a 1.1.0 release. Let me know if you'd like to move forward with this PR, and I'll update anything left outstanding.