Support for non-hourly offset timezones - refs issues 55 and 76 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 24, 2015 10:21
…() to account for time zones that have a 30-minute offset. PHPUnit tests pass.
…e zone with non-hour offset is used
|
This look great. Can you remove all of the extra spacing that was added throughout the PR? I'd like the code base to have a consistent style and not introduce spaces between everything in parenthesis or to line up equal assignments. |
|
Ah yes; saw that as well. No problem; I'll make the change and update this PR. |
Removed code formatting that was added.
|
Updated. |
|
I'd wager that this PR also fixes #91... 👍 |
mtdowling
added a commit
that referenced
this pull request
Oct 11, 2015
Support for non-hourly offset timezones - refs issues 55 and 76
This was referenced Oct 11, 2015
Closed
peter279k
pushed a commit
to peter279k/cron-expression
that referenced
this pull request
Nov 25, 2020
Add compatibility with PHP 8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great package!
Our project has a requirement to support non-hourly offset timezones ('America/St_Johns' for example) and a colleague of mine has created a fork which resolves the "Impossible CronExpression" issue when using these timezones.
This PR should help resolve:
#55
#76
Thanks,
Alan