Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make it work with Guava's Optional type #23

Closed
astubbs opened this issue Nov 11, 2013 · 6 comments
Closed

Can't make it work with Guava's Optional type #23

astubbs opened this issue Nov 11, 2013 · 6 comments

Comments

@astubbs
Copy link
Contributor

astubbs commented Nov 11, 2013

Need a way to register a factory for Optional types, or more generally, a way to register a factory for any given type would be better than nothing. This is without having to modify the original class too.

@astubbs
Copy link
Contributor Author

astubbs commented Nov 15, 2013

I'm looking at implementing a factory registration system to externally register custom factories for certain types (which will solve optional), instead of having to annotate classes (useful for code that's not your own). Let me know if you've got any tips or existing near solutions.

@astubbs
Copy link
Contributor Author

astubbs commented Nov 15, 2013

Have implemented it myself, among other things; #24

@astubbs
Copy link
Contributor Author

astubbs commented Apr 15, 2014

This is waiting for pull requests #39, #40, #41, #42 to be processed before updating work on this as it depends on those branches currently. At my company we're continuing on with my older fork that has the guava support working.

@daivanov
Copy link
Collaborator

Tests for the reported problem was pushed to new branch guava in order to avoid having Guava as dependency for PODAM
a90a32e
Closing the issue as tests succeed.

@mtedone
Copy link
Owner

mtedone commented Jan 31, 2015

Daniil, it's a good idea to support additional types in PODAM without direct dependencies. We should be looking at loading external types at runtime through the Classloader. Podium users' responsibility will be to make sure that these libraries are available at runtime. For tests, we could include Guava with scope 'test' so that it won't end up in the production code. Once this work is done, we can remove the Guava branch.

@daivanov
Copy link
Collaborator

daivanov commented Feb 1, 2015

This tests is complimentary. There is no fix patch related to this test. So if there are two possibilities: remove the branch or merge it to master.
guava was added in test scope:
a90a32e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants