-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't make it work with Guava's Optional type #23
Comments
I'm looking at implementing a factory registration system to externally register custom factories for certain types (which will solve optional), instead of having to annotate classes (useful for code that's not your own). Let me know if you've got any tips or existing near solutions. |
Have implemented it myself, among other things; #24 |
Tests for the reported problem was pushed to new branch |
Daniil, it's a good idea to support additional types in PODAM without direct dependencies. We should be looking at loading external types at runtime through the Classloader. Podium users' responsibility will be to make sure that these libraries are available at runtime. For tests, we could include Guava with scope 'test' so that it won't end up in the production code. Once this work is done, we can remove the Guava branch. |
This tests is complimentary. There is no fix patch related to this test. So if there are two possibilities: remove the branch or merge it to master. |
Need a way to register a factory for Optional types, or more generally, a way to register a factory for any given type would be better than nothing. This is without having to modify the original class too.
The text was updated successfully, but these errors were encountered: