Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup mtekk_admkinKit::version_check() messages #133

Closed
mtekk opened this issue Dec 27, 2015 · 1 comment
Closed

Cleanup mtekk_admkinKit::version_check() messages #133

mtekk opened this issue Dec 27, 2015 · 1 comment
Assignees
@mtekk
Labels
Blocker/Blessed Bug
Milestone
5.4.0

Comments

@mtekk
Copy link
Owner

mtekk commented Dec 27, 2015

There is a bug in this function that causes the "Migrate Now" message to appear on the first visit to the settings page. In reality, we no longer need to show that message since the way default settings are handled now is much more robust than in the past.
@mtekk mtekk self-assigned this Dec 27, 2015
@mtekk mtekk added this to the 5.4.0 milestone Dec 27, 2015
mtekk added a commit that referenced this issue Dec 31, 2015
@mtekk
Some rewording, and cleanup of the version_check function, part of #133
588d673
@mtekk
Copy link
Owner Author

mtekk commented Jan 1, 2016

This should be fixed, pending unit tests

mtekk added a commit that referenced this issue Jan 10, 2016
@mtekk
Add skeleton for mtekk_adminKit unit tests. Add tests for version_che…
a122712 
…ck(). Part of #133
@mtekk mtekk removed the Needs Tests label Jan 10, 2016
@mtekk mtekk closed this as completed Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtekk mtekk

Labels
Blocker/Blessed Bug
Projects
None yet
Milestone
5.4.0
Development

No branches or pull requests
1 participant
@mtekk