feat: add github issues link to regex #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: when I opened the PR felt that's really similar to open sauced, then noticed you are one of the contributors there :) |
|
Yeah, great project 🤩 |
mtfoley
requested changes
Sep 18, 2023
|
Thank you for the suggestions! Just solved it and all tests passed 👍 |
mtfoley
reviewed
Sep 25, 2023
There was a problem hiding this comment.
actually really surprised that anything in dist would be affected. perhaps there's a different node version or something. I'll probably just merge this and make sure things are cleaned up on the next release.
mtfoley
approved these changes
Sep 25, 2023
|
Thank you for accepting it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR add the extra regex to detect the issues link in the body.
Related Tickets & Documents
Closes #384
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?