Update to support favourite 1 and 2 presets if the hub supports it. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! thank you. Currently planning on doing a bit of a rewrite/rework of the project when I finally get some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reached out to neoblinds support to ask about being able to support both favourite 1 and 2 which my controller allows and they told me the following can be used.
favourite 1: either "gp" or "i1"
favourite 2: "i2"
Updated the required files and used the value of 51 for favourite 2, and left 50 for favourite 1.
Tested with the cover.py from release v11 since the current version from master give me an error on startup, but didn't want to revert any of your changes so left that file alone.