Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docker] Add Docker support #2

Closed
benjaminch opened this issue Sep 16, 2019 · 2 comments
Closed

[Docker] Add Docker support #2

benjaminch opened this issue Sep 16, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@benjaminch
Copy link
Contributor

Hello !

First, I wanted to thank you for this project, it's really awesome ! I am working on learning RUST and apply it to WASM and this project is awesome I I would be happy to start to contribute to it in the next future :)

My first humble contribution if you are okay with it will be to add Docker support to easily be able to deploy it (I am using Kubernetes).

I will push a PR to add this support, please let me know what you think ! :)

Cheers !
benjaminch referenced this issue in benjaminch/wasmbooth Sep 16, 2019
@benjaminch
[Docker] Add Docker support
18250e1 
This CL introduces docker support to this project.

Issue: #2
@benjaminch benjaminch mentioned this issue Sep 16, 2019
Merged
@benjaminch
Copy link
Contributor Author

Hey @mtharrison, I was wondering if you had time to look at this one and if it makes sense to you?
Thanks :)

mtharrison pushed a commit that referenced this issue Dec 31, 2019
@narate @benjaminch
- Add docker-compose support (#2)
107614c 
- Change docker image to node:slim to reduce image size
- Change EXPOSE in Dockerfile to match with opening PORT
- Update README.md
@mtharrison
Copy link
Owner

#3

@mtharrison mtharrison added the enhancement New feature or request label Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtharrison @benjaminch