Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests on wasm target #2138

Open
infogulch opened this issue Oct 26, 2023 · 0 comments
Open

Fix failing tests on wasm target #2138

infogulch opened this issue Oct 26, 2023 · 0 comments

Comments

@infogulch
Copy link
Contributor

I made some changes to the way wasm builds in CI in #2137, basically making it a standalone target instead of piggybacking on the ubuntu/x86 build, and building directly with cargo instead of using wasm-pack.

While developing that change I noticed that running a cargo test with the wasm target fails:

cargo test --target wasm32-unknown-unknown --no-default-features --all --verbose

In order to keep the project moving I disabled failed tests failing the build, which is clearly not a desirable state to be in. Ideally the warnings and errors produced when running this command would be fixed so we can put the test guardrails back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant