Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: compile wasm separately; default 22.04; matrix #2137

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

infogulch
Copy link
Contributor

This makes wasm build separately as its own architecture target in the build matrix, and compiles directly instead of using wasm-pack.

⚠️ This also changes the test step to not fail the build because it currently fails on wasm. ⚠️

I think this is a reasonable intermediate step until the wasm tests are fixed, after which we can remove the || echo "::warning at the end of line 66 so that failing tests will fail the build again.

In particular, I would expect this command to succeed without producing any errors or warnings:

cargo test --target wasm32-unknown-unknown --no-default-features --all --verbose

@triska
Copy link
Contributor

triska commented Oct 26, 2023

Thank you so much for working on this!

If there is anything we need to do later to get the tests working as intended, could you please consider filing this as an issue with a small description, similar to the text above? In addition to serving as a reminder, this may also attract interested contributors who may be able to solve this. Thank you a lot!

@triska
Copy link
Contributor

triska commented Oct 26, 2023

One other issue I noticed: What about more recent Ubuntu versions, would it be useful or even possible to also automatically build releases for them? It may help with compatibility and ease the selection.

@infogulch
Copy link
Contributor Author

Thanks, I opened an issue for failing wasm tests per your suggestion. We may want to ping potentially interested parties there.

We're currently building for 20.04 and 22.04, which are the linux OSes supported by github actions as of now. https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

Once a new release is tagged the binaries would be published automatically. See #2044

@mthom mthom merged commit f4e5426 into mthom:master Oct 26, 2023
11 checks passed
@mthom
Copy link
Owner

mthom commented Oct 26, 2023

Great! thanks for this @infogulch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants