Fix multibyte text problem in blockquotes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
👍 thanks @cameron1729 |
mtibben
added a commit
that referenced
this pull request
Mar 16, 2016
Fix multibyte text problem in blockquotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since converting the string functions to their mb_ equivalents,
PREG_OFFSET_CAPTUREcan now be "incorrect", the mb_ functions give the position of characters in the string, wherasPREG_OFFSET_CAPTUREgives the byte offset. This meant that for some strings,mb_substrinconvertBlockquoteswas truncating the strings in the wrong place.