-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always assumes repo is tagged using SemVer #21
Comments
I found this, that should help to know what makes a string parseable into pep440: https://github.com/pypa/packaging/blob/d59efa2141210447ae21c4d48813d720e0d1dbfd/packaging/version.py#L225-L254 |
Hi! Sorry for the late response, and thanks for pointing this out. I'll definitely relax
For reference, this is also available from the command line as |
This is now fixed in 1.6.0. |
See this session:
It seems that even when I add
--style pep440
to the command, dunamai only tries to find tags formatted with semver, because it's using this regexp:dunamai/dunamai/__init__.py
Lines 26 to 31 in 14a9891
With that regexp for example, these tags would fail:
So I think that it should:
v
be optionalAs a workaround, there's the possibility to pass a custom pattern if running from python:
dunamai/dunamai/__init__.py
Lines 851 to 857 in 14a9891
The text was updated successfully, but these errors were encountered: