Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support git tags with backslacks #17

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Support git tags with backslacks #17

merged 1 commit into from
Apr 27, 2021

Conversation

jess-sol
Copy link
Contributor

@jess-sol jess-sol commented Apr 26, 2021 •
edited
Loading

Fixes #16

@jess-sol
Copy link
Contributor Author

Branch is named wrong, should be fix-16, not fix-13

@mtkennerly mtkennerly added the bug Something isn't working label Apr 27, 2021
mtkennerly
mtkennerly approved these changes Apr 27, 2021
View reviewed changes
Copy link
Owner

@mtkennerly mtkennerly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! This is a great find.

The GitHub workflow is failing for an unrelated reason (Bazaar setup), so no worries there.

@mtkennerly mtkennerly merged commit 1e929b2 into mtkennerly:master Apr 27, 2021
@jess-sol
Copy link
Contributor Author

Yeah, I was wondering why too. I did run all tests locally with tox, and they passed though, so no worries.

Thanks! 💯

@jess-sol jess-sol deleted the topic/fix-13 branch April 27, 2021 00:38
@mtkennerly mtkennerly added this to the v1.5.5 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtkennerly mtkennerly mtkennerly approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.5.5
Development

Successfully merging this pull request may close these issues.

Pick up tags with / in name
2 participants
@jess-sol @mtkennerly