-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do certain games show saved backups but others not? #69
Comments
This is because of name mismatches like When performing backups/restores, the plugin uses the For now, if you set "look up with another title" to the normalized title, then it'll list the backups. |
I see, that makes sense.I briefly checked the source code and from what I understand Ludusavi Playnite performs a backup list check and caches it to a dictionary. As far as I know, Ludusavi manifest obtains stores Ids already that could be used to match too. This gives me the idea of separating the backups handling to an specific class that would also support obtaining backups by id by cache'ing the storeIds public class BackupsManager
{
private Dictionary<string, List<ApiBackup>> gameNameDictionary;
private Dictionary<string, string> steamIdToNameDictionary;
public void RefreshLudusaviBackups()
{
// Refresh gameNameDictionary
// steamIdToNameDictionary is updated with the steam id as key and the name used in gameNameDictionary as a value
}
private List<ApiBackup> GetBackups(string gameName)
{
// Do what is already being done
}
private List<ApiBackup> GetBackupsBySteamId(string steamId)
{
if (steamIdToNameDictionary.TryGetValue(steamId, out var gameName))
{
return GetBackups(gameName);
}
return somethingsomething;
}
public string GetGameBackups(Game game)
{
if (gameNameDictionary.ContainsKey(storeId))
{
return gameNameDictionary[storeId];
}
else if (game.PluginId == steamPluginId)
{
return GetBackupsBySteamId(game.Id)
}
}
....
} In this implementation, In my opinion this approach could work, while making it more extensible in the future but without knowing how Ludusavi itself works I don't know if it's feasible. Separating backup concerns from the main plugin class is also in my opinion an added benefit. |
It could definitely work, but I'd like to keep the ID/normalization checks in Ludusavi for consistency and reuse. I think I'll explore adding a bulk equivalent of the
Yeah, it could definitely use some cleanup. I'll look into that. |
This will be fixed once Ludusavi 0.24.0 comes out. It will include an |
Hi, just wondering about this. For a reason unknown to me, most games do show backed up items in the context menu correctly, e.g.
Persona 5 Royal
:But others, like
Nier: Automata
do not show backed up items:Saves are being backed up without issues on game close:
Another example is
Resident Evil 2
:The text was updated successfully, but these errors were encountered: