Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for start service argument passing #6

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

Enet4
Copy link
Contributor

@Enet4 Enet4 commented Mar 20, 2020

This adds the option --pass-start-args to shawl so that arguments given on service start can be passed into the managed executable.

So for example, we can create a new service like this:

shawl add --name myservice --pass-start-args -- C:\Path\to\file.exe

Now when starting the service like this:

sc start myservice extra

The argument extra is also passed to file.exe.

I believe that this is a useful feature to become available upstream (we'll likely be using it ourselves in our fork). Tests were written as well. Please let me know if there is something you'd like addressed or explained.

- --pass-start-args makes it so that arguments on service `start` are
   appended to the full command
- add integration test to --pass-start-args option
@mtkennerly
Copy link
Owner

Thanks, this is great! I didn't even realize that start arguments were a thing. I'll plan to make a new release this weekend with the addition (plus I might try to squeeze in some logging options if I can get to it).

@mtkennerly mtkennerly merged commit d4eb1b0 into mtkennerly:master Mar 20, 2020
@mtkennerly
Copy link
Owner

@Enet4, this is now available in v0.6.0, along with log rotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants