Bug: Fixing figure and image tag spacing to be equivalent #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #199.
As pointed out in #199 there was more top/bottom margin spacing on
<figure>
tags as opposed to<image>
tags. In order to make the spacing (margins) equivalent, this required a few minor CSS rules to be applied to<figure>
and<figcaption>
tags. The rules in this PR make the spacing for the tags exactly the same now.As you can see in the screen caps below, the margins are now the same for above/below
<image>
tags as well as<figure>
tags:Before bugfix
As you can see the current site has 44px computed margins above and below
figure
tags.And on
<image>
tags, currently the margins are based on the parent<p>
tag and has a computed margin of 25.74px above and below.After bugfix
With the code contained in this bugfix, you can see the computed margins for
<figure>
tags are now 0 on top and 25.74px on the bottom. So, the bottom margins are now exactly the same.Finally, you can see that above the figures are going to be a
<p>
tag which has a computed bottom margin of 25.74px already, so now the top margins match exactly just like the current<image>
tags.