Skip to content

Commit

Permalink
Update Contributing guide to say merging onto master is okay (#564)
Browse files Browse the repository at this point in the history
  • Loading branch information
mtlynch committed Mar 29, 2024
1 parent 29b69ba commit 0f616c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ npm run format
- Good: `Fix dropped keystrokes on Firefox`
- Bad: `Fix issue`
- If your PR is not ready for review, mark it as "draft."
- [Rebase your changes](https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase) onto the latest `master` commit so that there are no merge conflicts.
- Merge or [rebase](https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase) your changes with the latest `master` commit so that there are no merge conflicts.
- Your PR must pass build checks in CI before it will be considered for merge.
- You'll see a green checkmark or red X next to your PR depending on whether your build passed or failed.
- You are responsible for fixing formatting and tests to ensure that your code passes build checks in CI.
Expand Down

0 comments on commit 0f616c9

Please sign in to comment.