Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MaxMind Supplied Test DBs #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Use MaxMind Supplied Test DBs #9

wants to merge 7 commits into from

Conversation

mtodd
Copy link
Owner

@mtodd mtodd commented Jul 11, 2012

I've contacted MaxMind and they've been gracious enough to provide us with test databases that we can distribute along with the client library to simplify testing. This pull includes these new files and slight refactoring to the tests.

This also includes a fix for #7 that only attempts lookups of region_name when region is found, which was previously causing segfaults.

@mtodd
Copy link
Owner Author

mtodd commented Jul 11, 2012

Awaiting some updated test DBs from the MaxMind contact (to get the tests passing) and some further details before merging.

@alindeman
Copy link
Contributor

@mtodd, any news on the test DBs?

@findchris
Copy link
Contributor

While we await these test DBs from MaxMind, this gem crashes (see #7). Are the test DBs worth blocking a fix for a fatal error condition?

@findchris
Copy link
Contributor

Is everyone still using this gem? If segfault-fixes are not being merged on this project, is there another that you all are using? We've been using our own fork, but we thought that would be temporary.

@alindeman
Copy link
Contributor

@mtodd, I don't feel like I have the time or expertise anymore to maintain this gem. Thoughts on inviting new maintainers from the folks submitting pull requests?

@alindeman
Copy link
Contributor

@findchris, are you interested in maintaining the gem?

@findchris
Copy link
Contributor

@alindeman I would be interested, but I've been using the geoip-c gem, and unless there is a compelling reason to maintain this one, I'll probably pass.

@findchris
Copy link
Contributor

@alindeman I was clearly confused in my reply. This is the geoip-c gem, and I guess I thought I was responding to a different request.

That said, I am interested in maintaining this gem, as this gem deserves more attention.

@alindeman
Copy link
Contributor

Right, this is the geoip-c gem. I'm 👍 to make you a committer. I'm not using this gem day-to-day anymore, so I'm not a good candidate to keep things moving. @mtodd has the final call though.

@findchris
Copy link
Contributor

Cool. Hopefully @mtodd will chime in here.
By the way, @alindeman, are you using any geo data anymore, and if so, what gem are you using to access that data (out of curiosity)?

@alindeman
Copy link
Contributor

By the way, @alindeman, are you using any geo data anymore, and if so, what gem are you using to access that data (out of curiosity)?

Ah, I'm just not currently working on a project that uses an IP -> geo database anymore. I believe the project itself is still using this gem, but other folks are working on it now.

@mtodd
Copy link
Owner Author

mtodd commented Aug 18, 2013

I'm very eager to find someone to take over maintaing this gem. I simply don't have the time or attention to properly care for it and know that that won't be changing any time soon.

@findchris
Copy link
Contributor

@mtodd Understood. Can I maintain the project or be a committer then?

@luislavena luislavena mentioned this pull request Oct 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants