Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -e option: Interrupt via Ctrl+C, Proper Makefile, and Cleanup sl.h #17

Closed
wants to merge 3 commits into from
Closed

Conversation

ryanmjacobs
Copy link
Contributor

Add -e option to allow interrupt via Ctrl+C. So users can, alias sl='sl -e' if they don't want to wait each time for sl to finish running.

  • Makefile now includes: install, uninstall, and clean. Therefore, users can install sl by running:
make
make install
  • Add header guards to sl.h, and move function prototypes to sl.h.
  • README.ja.md and sl.1.ja still need to be updated (I don't know Japanese).

@mtoyoda
Copy link
Owner

mtoyoda commented Jun 17, 2014

Sorry for replying late.
The -e option is a local extension for the debian package.
I'm still wondering that users really need the option.

@ryanmjacobs
Copy link
Contributor Author

That's fine if you don't merge it.
I just created this fork because I wanted the -e option on my system.
If other users want it too, they can grab it from my fork.

@jeandrek
Copy link

I get impatient because I mistype ls as sl very often 😛

@jeandrek
Copy link

Hm. I applied this patch and the manpage has changed and the source does say it's changed but -e doesn't work...

@ryanmjacobs
Copy link
Contributor Author

@Jonathan50 Sorry for the late reply. My inbox has been stuffed lately.

Can you please try these commands in order?

$  git clone https://github.com/ryanmjacobs/sl
$ cd sl
$ make
$ ./sl -e

@jeandrek
Copy link

It works. But if I modify the PKGBUILD to apply the patch it doesn't work.

@ryanmjacobs
Copy link
Contributor Author

Can you try this PKGBUILD?

(I basically took sl-git, and switched out mtoyoda with ryanmjacobs)

@jeandrek
Copy link

It works great thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants