Use the internal URL for nginx proxy pass #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ghost_config_url` contains the external URL for the site. It's used in the ghost config.js to set the site URL. By default, the value of `ghost_config_url` is set to the internal ghost URL (i.e. 127.0.0.1:2368). If the user overrides that setting to set it to the public domain name for the blog (e.g. http://codebeef.com), while maintaining the value of `ghost_config_server`, then the blog should be configures with the correct domain name, and the ghost instance should still be set to bind to 127.0.0.1:2368, with this value set in the proxy_pass for nginx. Currently, changing the `ghost_config_url` also changes the proxy_pass setting. This commit changes that so that the proxy_pass setting comes from the `ghost_config_server` values.
|
Thank you! 👍 |
|
Hey @jesperrasmussen ! Yeah, this is definitely not fresh on my mind. I need to test this locally and get a grasp of it once more. I'll get back to you as soon as I manage to do it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghost_config_urlcontains the external URL for the site. It's used inthe ghost config.js to set the site URL.
By default, the value of
ghost_config_urlis set to the internal ghostURL (i.e. 127.0.0.1:2368). If the user overrides that setting to set it
to the public domain name for the blog (e.g. http://codebeef.com), while
maintaining the value of
ghost_config_server, then the blog should beconfigures with the correct domain name, and the ghost instance should
still be set to bind to 127.0.0.1:2368, with this value set in the
proxy_pass for nginx.
Currently, changing the
ghost_config_urlalso changes the proxy_passsetting. This commit changes that so that the proxy_pass setting comes
from the
ghost_config_servervalues.