Add error handling for invalid input regexes #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds error handling for invalid input regexes on any of the test selection mechanisms. Now when an invalid regex is encountered an error message will be printed and then stestr will exit. The logic in selection.py needed to be reworked slightly to differentiate between invalid regex in input filters and the whitelist file.
mtreinish
force-pushed
the
invalid-regex-error
branch
from
3745141
to
6258997
Compare
masayukig
approved these changes
Jun 16, 2018
| try: | ||
| _filters.append(re.compile(f)) | ||
| except re.error: | ||
| print("Invalid regex: %s provided in filters" % f) |
There was a problem hiding this comment.
I was thinking like these error messages should be written to stderr. But it's a separate thing. We already do it in the others.
I'll push a patch to fix it if we should. What do you think?
There was a problem hiding this comment.
Yeah using stderr is probably the proper way to handle this. It's a pattern I've used in other places, mostly because I'm lazy. I think you pushing a follow up patch to switch all of those places to use stderr is a good idea.
There was a problem hiding this comment.
OK, cool. I'll push a patch for that later.
masayukig
added a commit
to masayukig/stestr
that referenced
this pull request
Jun 18, 2018
This commit makes warning and error messages use stderr for output. Originally, those messages use stdout. However, those messages should use stderr instead because of the responsibility. This commit keeps the original exit codes for the backward compatibility. Related-PR: mtreinish#182
masayukig
added a commit
to masayukig/stestr
that referenced
this pull request
Jun 18, 2018
This commit makes warning and error messages use stderr for output. Originally, those messages use stdout. However, those messages should use stderr instead because of the responsibility. This commit keeps the original exit codes for the backward compatibility. Related-PR: mtreinish#182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds error handling for invalid input regexes on any of the
test selection mechanisms. Now when an invalid regex is encountered an
error message will be printed and then stestr will exit. This should hopefully
make it easier to identify bad user input, like described in #181.
The logic in selection.py needed to be reworked slightly to
differentiate between invalid regex in input filters and the whitelist
file.