Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use stdlib based unittest runner for py >=3.5 #265

Merged
merged 2 commits into from
Aug 28, 2019

Commits on Aug 16, 2019

  1. Only use stdlib based unittest runner for py >=3.5

    The stdlib python test runner introduced in #256 was written assuming a
    python stdlib from python 3.5 or newer. Since we only officially support
    running on python 3.5 or newer when we added the logic to switch between
    the stdlib runner and the old testtools based runner we just said
    python >=3.0.0. However, despite our official support status for python
    >2.7,<3.5 there are still users out there running stestr on these python
    versions. The new test runner will not work for those users because
    unittest in stdlib changed in python 3.5 (as an aside this is the same
    issue I've been hitting in my attempts to get unittest2 removed from
    testtools). To address this problem a simple fix is to just change the
    if statement to be a bit more explicit and only use the new runner for
    python 3.5 or newer. This way stestr is more explicit about where the
    newer runner actually works and this should hopefully unbreak any users
    out there still using python 3.0 to 3.4.
    
    Fixes #264
    mtreinish committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    136027c View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. Configuration menu
    Copy the full SHA
    8ae34af View commit details
    Browse the repository at this point in the history