Use subunit-trace #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
force-pushed
the
use-subunit-trace
branch
from
65d3a9a
to
e5c2901
Compare
mtreinish
force-pushed
the
use-subunit-trace
branch
from
e5c2901
to
1cd10e9
Compare
This commit copies over the subunit-trace and colorizer (it's only in repo dependency) from the os-testr project. [1] These modules will be used as the new default output filter from stestr, but to avoid a potential circular dependency (the long term plan is to switch os-testr to use stestr underneath) we need the subunit-trace modules to live locally. [1] http://git.openstack.org/cgit/openstack/os-testr
mtreinish
force-pushed
the
use-subunit-trace
branch
from
1cd10e9
to
76ac4f6
Compare
masayukig
requested changes
Jul 28, 2017
stestr/commands/load.py
Outdated
| output_result = testtools.StreamResultRouter(output_result) | ||
| cat = subunit.test_results.CatFiles(sys.stdout) | ||
| output_result.add_rule(cat, 'test_id', test_id=None) | ||
| start_time = datetime.datetime.utcnow() |
There was a problem hiding this comment.
This causes an error[1] when pretty_out is True(--no-subunit-trace specified).
[1] UnboundLocalError: local variable 'start_time' referenced before assignment
There was a problem hiding this comment.
Yep, start time isn't defined in the case pretty_out is false. So when L157 is run there is no start time defined. I should have put start time definition out one indent level and to L144. I'll respin it right now
This commit switches the default output filter to be subunit trace. This is configurable and if people desire they can either use the old output format, or straight subunit. But, the subunit-trace output is a lot more useful by default.
We had to port the colorizer output modules when we migrated subunit-trace from os-testr. This commit puts it to use by adding cli options to stestr run and stestr load, the only 2 commands which currently use subunit-trace, to enable colorized output.
This commit adds the subunit-trace output filter to the stestr last command. This is enabled by default, the last command is used to see the results of the last command and the subunit-trace filter makes viewing test results much easier.
This commit adds docs for subunit-trace and other output filters, as well as providing an end user guide to the stestr manual.
mtreinish
force-pushed
the
use-subunit-trace
branch
from
76ac4f6
to
609c0a9
Compare
|
ok, the latest revision should have fixed the issue you caught. Thanks for testing and reviewing this and all the other patches this week. |
masayukig
approved these changes
Jul 28, 2017
|
(I really don't know the github workflow... :-p) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds subunit-trace output filtering to stestr. The code is copied directly from the os-testr project [1]. This enables subunit-trace by default on the run and last commands, and enables it as an option on the load command. Right now most of the subunit-trace output options are hard coded, with the only exception being colorized output which there is a config flag for. In the future we might add support for more customized output.
One thing to note is that to avoid a potential namespace collision this does not add the console_script entrypoint for the subunit-trace command. If/when os-testr switches to using stestr we might be able to figure out a deprecation path in os-testr and remove the forked copy of subunit-trace.
Closes Issue #22
[1] http://git.openstack.org/cgit/openstack/os-testr