Skip to content

Commit

Permalink
Makefile: add -failfast to e2e-op
Browse files Browse the repository at this point in the history
When an MCO e2e test fails, we keep running all the others till the end.
That has the shortcoming of not providing the journal for any test that
failed. This has been found in https://bugzilla.redhat.com/show_bug.cgi?id=1827712
The bug itself needs journal to debug.
Adding -failfast will halt test execution at the first failure which I think it's
generally better for e2e-op as we get a fast feedback from tests.
To further debug that BZ tho we'd need to capture the last boot as well which I'll
fix in a follow up PR to openshift/release.

Signed-off-by: Antonio Murdaca <runcom@linux.com>
  • Loading branch information
runcom authored and openshift-cherrypick-robot committed Apr 26, 2020
1 parent 5803275 commit 3a6f552
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,4 @@ Dockerfile.rhel7: Dockerfile Makefile

# This was copied from https://github.com/openshift/cluster-image-registry-operato
test-e2e:
go test -timeout 120m -v$${WHAT:+ -run="$$WHAT"} ./test/e2e/
go test -failfast -timeout 120m -v$${WHAT:+ -run="$$WHAT"} ./test/e2e/

0 comments on commit 3a6f552

Please sign in to comment.